FAQ: Submitting Code to comply with RCL Licence Terms | OPC UA Implementation: Stacks, Tools, and Samples | Forum

Avatar
Search
Forum Scope


Match



Forum Options



Minimum search word length is 3 characters - maximum search word length is 84 characters
Lost password?
sp_Feed sp_PrintTopic sp_TopicIcon
FAQ: Submitting Code to comply with RCL Licence Terms
Avatar
Randy Armstrong
Admin
Forum Posts: 532
Member Since:
05/30/2017
sp_UserOfflineSmall Offline
1
05/22/2018 - 15:21
sp_Permalink sp_Print sp_EditHistory

Any member company that uses the OPC-F code and needs to comply with their obligations under the RCL licence should do the following:

  1. Create a fork on the appropriate OPC-F GitHub repo;
  2. Add your fixes;
  3. Compile and test (Changes that do not compile are not acceptable);
  4. Document (Explain why the changes were made and when they are needed);
  5. Create a pull request.

Your obligations are fulfilled once the pull request exists, all files compile, documentation exists and the changes are accessible to all. 

When deciding what changes need to submitted the rule of thumb should be: if you change a file distributed by the OPC-F then that change must be given back. If you extend the library with subclasses or helper functions then that does not need to be given back unless the changes require your new code to be compiled into the same library as the OPC-F code. If the latter then the new code is too tightly coupled to be considered a true extension and must be given back.

Avatar
Dmitry Farberov
Member
Members
Forum Posts: 11
Member Since:
06/30/2014
sp_UserOfflineSmall Offline
2
05/27/2020 - 07:16
sp_Permalink sp_Print

What about changing project files to target a different .NET Framework (4.8 in our case)?

Avatar
Randy Armstrong
Admin
Forum Posts: 532
Member Since:
05/30/2017
sp_UserOfflineSmall Offline
3
05/27/2020 - 08:12
sp_Permalink sp_Print

Changing the framework is a trivial change that does not need to be given back.

Avatar
Dmitry Farberov
Member
Members
Forum Posts: 11
Member Since:
06/30/2014
sp_UserOfflineSmall Offline
4
05/27/2020 - 08:45
sp_Permalink sp_Print

How do I go about getting access to GitHub to be able to create a fork?

Avatar
Randy Armstrong
Admin
Forum Posts: 532
Member Since:
05/30/2017
sp_UserOfflineSmall Offline
5
05/28/2020 - 15:36
sp_Permalink sp_Print sp_EditHistory

You use your own account to create the fork and submit the pull request.

Avatar
Dmitry Farberov
Member
Members
Forum Posts: 11
Member Since:
06/30/2014
sp_UserOfflineSmall Offline
6
05/29/2020 - 07:51
sp_Permalink sp_Print

This is the error I get:

git -c diff.mnemonicprefix=false -c core.quotepath=false --no-optional-locks push -v --set-upstream origin CertificateValidator_Changes:CertificateValidator_Changes
remote: Permission to OPCFoundation/UA-.NETStandard.git denied to DmitryFarberov.
fatal: unable to access 'https://github.com/OPCFoundation/UA-.NETStandard.git/': The requested URL returned error: 403
Pushing to https://github.com/OPCFoundati.....andard.git

Avatar
Randy Armstrong
Admin
Forum Posts: 532
Member Since:
05/30/2017
sp_UserOfflineSmall Offline
7
05/29/2020 - 16:15
sp_Permalink sp_Print sp_EditHistory

You need to push to the fork in your account and then create a Pull Request from the GitHub website.

Forum Timezone: America/Phoenix
Most Users Ever Online: 202
Currently Online: Romain Labussiere, Mircea-Stefan Radu
Guest(s) 24
Currently Browsing this Page:
1 Guest(s)
Top Posters:
Forum Stats:
Groups: 2
Forums: 9
Topics: 796
Posts: 2359